Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug (ci): changeset should only be required on changes to cli and outputted app #1623

Closed
c-ehrlich opened this issue Oct 25, 2023 · 0 comments · Fixed by #1625
Closed

bug (ci): changeset should only be required on changes to cli and outputted app #1623

c-ehrlich opened this issue Oct 25, 2023 · 0 comments · Fixed by #1625
Labels
📌 area: ci Relates to CI / GitHub Actions 🙋‍♂️ help wanted Extra attention is needed

Comments

@c-ehrlich
Copy link
Member

c-ehrlich commented Oct 25, 2023 •
edited
Loading

Describe the bug

Currently the CI throws an error on any PR that doesn't include a changeset. However the intended behaviour is that changesets should only be required on changes to the CLI or scaffolded app, ie anything in /cli (or maybe even anything in /cli except readmes etc)
@c-ehrlich c-ehrlich added 🙋‍♂️ help wanted Extra attention is needed 📌 area: ci Relates to CI / GitHub Actions labels Oct 25, 2023
@Jacksonmills Jacksonmills mentioned this issue Oct 25, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📌 area: ci Relates to CI / GitHub Actions 🙋‍♂️ help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: ⚡ Add /cli change validation to CI workflow Jacksonmills/create-t3-app
1 participant
@c-ehrlich