feat: improve boolean coercion of SKIP_ENV_VALIDATION (#1358)

* fix: incorrect behavior of SKIP_ENV_VALIDATION * improve boolean coercion of SKIP_ENV_VALIDATION * changesets --------- Co-authored-by: Pichaya Puttekulangkura <[email protected]>
t3-oss · Apr 14, 2023 · 1a8a97e · 1a8a97e · vercel · Apr 14, 2023
1 parent c48b38f
commit 1a8a97e
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 9 deletions.
diff --git a/.changeset/blue-walls-admire.md b/.changeset/blue-walls-admire.md
@@ -0,0 +1,7 @@
+---
+"create-t3-app": minor
+---
+
+improve boolean coercion of `SKIP_ENV_VALIDATION` environment variable
+
+If defined, "0" and "false" are now considered falsey values, all other values are considered truthy.
diff --git a/cli/template/base/next.config.mjs b/cli/template/base/next.config.mjs
@@ -1,16 +1,16 @@
 /**
- * Run `build` or `dev` with `SKIP_ENV_VALIDATION` to skip env validation.
- * This is especially useful for Docker builds.
+ * Run `build` or `dev` with `SKIP_ENV_VALIDATION` to skip env validation. This is especially useful
+ * for Docker builds.
  */
-!process.env.SKIP_ENV_VALIDATION && (await import("./src/env.mjs"));
+await import("./src/env.mjs");
 
 /** @type {import("next").NextConfig} */
 const config = {
  reactStrictMode: true,
 
  /**
- * If you have the "experimental: { appDir: true }" setting enabled, then you
- * must comment the below `i18n` config out.
+ * If you have `experimental: { appDir: true }` set, then you must comment the below `i18n` config
+ * out.
  *
  * @see https://github.com/vercel/next.js/issues/41980
  */

diff --git a/cli/template/base/src/env.mjs b/cli/template/base/src/env.mjs
@@ -38,7 +38,11 @@ const merged = server.merge(client);
 
 let env = /** @type {MergedOutput} */ (process.env);
 
-if (!!process.env.SKIP_ENV_VALIDATION == false) {
+const skip =
+ !!process.env.SKIP_ENV_VALIDATION &&
+ process.env.SKIP_ENV_VALIDATION !== "false" &&
+ process.env.SKIP_ENV_VALIDATION !== "0";
+if (!skip) {
  const isServer = typeof window === "undefined";
 
  const parsed = /** @type {MergedSafeParseReturn} */ (

diff --git a/cli/template/extras/src/env/with-auth-prisma.mjs b/cli/template/extras/src/env/with-auth-prisma.mjs
@@ -58,7 +58,11 @@ const merged = server.merge(client);
 
 let env = /** @type {MergedOutput} */ (process.env);
 
-if (!!process.env.SKIP_ENV_VALIDATION == false) {
+const skip =
+ !!process.env.SKIP_ENV_VALIDATION &&
+ process.env.SKIP_ENV_VALIDATION !== "false" &&
+ process.env.SKIP_ENV_VALIDATION !== "0";
+if (!skip) {
  const isServer = typeof window === "undefined";
 
  const parsed = /** @type {MergedSafeParseReturn} */ (

diff --git a/cli/template/extras/src/env/with-auth.mjs b/cli/template/extras/src/env/with-auth.mjs
@@ -56,7 +56,11 @@ const merged = server.merge(client);
 
 let env = /** @type {MergedOutput} */ (process.env);
 
-if (!!process.env.SKIP_ENV_VALIDATION == false) {
+const skip =
+ !!process.env.SKIP_ENV_VALIDATION &&
+ process.env.SKIP_ENV_VALIDATION !== "false" &&
+ process.env.SKIP_ENV_VALIDATION !== "0";
+if (!skip) {
  const isServer = typeof window === "undefined";
 
  const parsed = /** @type {MergedSafeParseReturn} */ (

diff --git a/cli/template/extras/src/env/with-prisma.mjs b/cli/template/extras/src/env/with-prisma.mjs
@@ -40,7 +40,11 @@ const merged = server.merge(client);
 
 let env = /** @type {MergedOutput} */ (process.env);
 
-if (!!process.env.SKIP_ENV_VALIDATION == false) {
+const skip =
+ !!process.env.SKIP_ENV_VALIDATION &&
+ process.env.SKIP_ENV_VALIDATION !== "false" &&
+ process.env.SKIP_ENV_VALIDATION !== "0";
+if (!skip) {
  const isServer = typeof window === "undefined";
 
  const parsed = /** @type {MergedSafeParseReturn} */ (