Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a chance to support Play 2.2 ? #47

Closed
indykish opened this issue Sep 4, 2013 · 27 comments
Closed

Is there a chance to support Play 2.2 ? #47

indykish opened this issue Sep 4, 2013 · 27 comments

Comments

@indykish
Copy link

indykish commented Sep 4, 2013

As Play 2.2 is in RC1, https://www.playframework.com/documentation/2.2.0-RC1/Home
I am wondering if the dependencies be moved to play 2.2 ?

@gakuzzzz
Copy link
Member

gakuzzzz commented Sep 4, 2013

Hi,

Yes, I will provide Play2.2 support.
However, since the Result class inheritances are thoroughly redesigned in Play2.2,
it difficult to keep same code as before.

so, probably the version of play2.2 support will be bumped.

thanks,

@indykish
Copy link
Author

indykish commented Sep 4, 2013

Cool. Thats great to hear. We are anxious to get our hands on it, as we would move to prod. in a month.

@gakuzzzz
Copy link
Member

gakuzzzz commented Sep 4, 2013

Alright! I'll try on this weekend!

@indykish
Copy link
Author

indykish commented Sep 4, 2013

No hurry. we are on 2.1.3 and play-auth works like a charm, so we are ok.

@mbablok
Copy link

mbablok commented Sep 5, 2013

Hi,

I am joining the waiting group for Play2.2 support.

Thanks!

gakuzzzz added a commit that referenced this issue Sep 8, 2013
@indykish
Copy link
Author

Is it prime time to use the branch play2.2. I see a tweet that play2.2 was released.
https://www.playframework.com/documentation/2.2.x/Highlights22

@indykish
Copy link
Author

I tried this "jp.t2v" %% "play2.auth" % "0.11.0-SNAPSHOT" but it doesn't resolve it. Have you published your 0.11.0-SNAPSHOT ?

@gakuzzzz
Copy link
Member

oh, sorry,
would you add https://oss.sonatype.org/content/repositories/snapshots into resolvers?

@indykish
Copy link
Author

Yup, I have it actually.

https://github.com/indykish/megam_play/blob/master/project/Build.scala

The problem seems to be that you have changed the artifactId to

 "play2-auth" 
 and 
"play2-auth-test" 

The dots(.) are changed to a dash(-)

(as seen in the pic) .

By changing that it works now.

Do you intend to change it ?

image

@indykish
Copy link
Author

Thank you very much for your swift fix. Very much appreciated.

@raulraja
Copy link

I have migrated my project to the latest snapshot in order to support 2.2.
Some of my action composition is now based on the new ActionBuilders that rely on a Request[A] while the loggedin method expects an implicit RequestWithAttributes. Is there a new way to get the loggedin object?
Furthermore how does the whole Stackable controller based authorization fit in with the new ActionBuilders and recommended ways to do action composition in Play 2.2?
thx

@gakuzzzz
Copy link
Member

I have answered here
t2v/stackable-controller#6 (comment)

thx!

@gakuzzzz
Copy link
Member

I have published new SNAPSHOT that contains #53 changes.

Please try it.

@alangalvino
Copy link

Hi,

I have tried the SNAPSHOT version with play 2.2.0 in my application and everything is ok!

@gakuzzzz
Copy link
Member

gakuzzzz commented Oct 8, 2013

Hi,

Thank you for the feedback!!
If there are no problem, I'll publish release version at an early date.

@indykish
Copy link
Author

indykish commented Oct 8, 2013

+1 . No problems here too. Ofcourse we use it in a diff. way.

@indykish
Copy link
Author

indykish commented Oct 8, 2013

Thank you Manabu Nakamura for your awesome work.

@raulraja
Copy link

raulraja commented Oct 8, 2013

We are using it here too in 2 different projects. Both still in development
but no problems son far. Great job!
On Oct 8, 2013 4:07 AM, "Manabu Nakamura" [email protected] wrote:

Hi,

Thank you for the feedback!!
If there are no problem, I'll publish release version at an early date.


Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-25860203
.

@gakuzzzz
Copy link
Member

gakuzzzz commented Oct 8, 2013

thanks more!
I'm glad to hear that!!

@GitsMcGee
Copy link

Hi @gakuzzzz. Any update on when you might want to officially planning on releasing 0.11.0?

@gakuzzzz
Copy link
Member

Hi @GitsMcGee,

That have block release of 0.11.0 are #54 and #58.
If these issue can resolve without changing play2-auth interface, I want to publish as soon as possible.
If these need interface changing, I want to include the change in 0.11.0.

Now, I think that #54 is not need changing interface.
I am considering abount #58.
If there are good idea of #58, please tell me :)

Since Play2.2.1-RC1 was published, I want to come to a conclusion by this weekend at the latest.

@GitsMcGee
Copy link

Thanks @gakuzzzz. Looking forward to trying out the newest version. #58 is a tricky one. I'll try to put some thought into it.

Thanks again for your hard work and an awesome module!

@djonmayer
Copy link

Hi.
Is new version here? :-)

@gakuzzzz
Copy link
Member

gakuzzzz commented Nov 8, 2013

Hi @djonmayer,

Sorry holding of 0.11.0 release.

@GitsMcGee
Copy link

Hi @gakuzzzz,

Is there any reason not to use 0.11-SNAPSHOT in production? It seems stable. Are you planning on making any major interface changes or are there any major bugs that are holding up the release? I know you are still waiting on #58, which may require interface changes. I don't see a very easy solution with that ticket, but it seems like a very rare use case, for what that's worth :).

@gakuzzzz
Copy link
Member

gakuzzzz commented Nov 9, 2013

Hi,

I agree that #58 is rare case.
I publish 0.11.0.

@gakuzzzz
Copy link
Member

gakuzzzz commented Nov 9, 2013

I have published 0.11.0 just now!
After a few hours, It will be synced on Maven Central.

@gakuzzzz gakuzzzz closed this as completed Nov 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants