-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support optional parameters for login #175
Comments
tototoshi
pushed a commit
to tototoshi/play2-auth
that referenced
this issue
Jul 12, 2016
tototoshi
pushed a commit
to tototoshi/play2-auth
that referenced
this issue
Jul 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
OAuth2Controller#login
andOAuth2Controller#link
doesn't support optional parameters.play2-auth/social/src/main/scala/jp/t2v/lab/play2/auth/social/core/OAuth2Controller.scala
Lines 20 to 22 in 2e60a53
To solve this problem, I think some changes (including API changes) is required. My idea is:
scope
argument because scope is optionalOAuth2Authenticator#getAuthorizationUrl
should takerequest
instead ofscope
The task of
login
is only redirecting to authorization url, so it is enough only to change the API ofOAuth2Authenticator#getAuthorizationUrl
. is this correct?The text was updated successfully, but these errors were encountered: