You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// TODO scope is optional in some services// TODO some services have more optional parameterdeflogin(scope: String) =AsyncStack(ExecutionContextKey->OAuthExecutionContext) { implicit request =>
To solve this problem, I think some changes (including API changes) is required. My idea is:
Remove the scope argument because scope is optional
OAuth2Authenticator#getAuthorizationUrl should take request instead of scope
The task of login is only redirecting to authorization url, so it is enough only to change the API of OAuth2Authenticator#getAuthorizationUrl. is this correct?
The text was updated successfully, but these errors were encountered:
tototoshi
pushed a commit
to tototoshi/play2-auth
that referenced
this issue
Jul 12, 2016
Currently,
OAuth2Controller#login
andOAuth2Controller#link
doesn't support optional parameters.play2-auth/social/src/main/scala/jp/t2v/lab/play2/auth/social/core/OAuth2Controller.scala
Lines 20 to 22 in 2e60a53
To solve this problem, I think some changes (including API changes) is required. My idea is:
scope
argument because scope is optionalOAuth2Authenticator#getAuthorizationUrl
should takerequest
instead ofscope
The task of
login
is only redirecting to authorization url, so it is enough only to change the API ofOAuth2Authenticator#getAuthorizationUrl
. is this correct?The text was updated successfully, but these errors were encountered: