Add "patch-remove" command #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: This should work analogous to #9 once it gets merged. |
esolitos
suggested changes
Aug 21, 2019
| } | ||
|
|
||
| protected function interact(InputInterface $input, OutputInterface $output) { | ||
| $dialog = $this->getHelperSet()->get('dialog'); |
There was a problem hiding this comment.
Maybe this dialog (and following) should be put as a Trait so can be shared between the two patch-add and patch-remove classes?
Or else have a common ancestor like PatchFileManipulatorAbstractCommand ?
Having a common ancestor could also help for adding/removing the patch with sharing all the options, because basically the two commands are very very similar.
There was a problem hiding this comment.
Thanks for the suggestions. Let's do it on a separate issue, after this feature has been committed. Because it has also an effect on the command that is not part of this issue/pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for #11