Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiling with make fails #36

Closed
moritzgubler opened this issue Jun 15, 2021 · 8 comments
Closed

compiling with make fails #36

moritzgubler opened this issue Jun 15, 2021 · 8 comments
Assignees

Comments

@moritzgubler
Copy link

It seems to me that the current makefile does not compile the third party part of the library. make in the base directory returns:

Compile penf_global_parameters_variables.F90
Compile penf_b_size.F90
Compile penf_stringify.F90
Compile penf.F90
Compile befor64_pack_data_m.F90
Compile befor64.F90
Compile stringifor_string_t.F90
src/lib/stringifor_string_t.F90:6:4:
6 | use face, only : colorize
| 1
Fatal Error: Cannot open module file ‘face.mod’ for reading at (1): No such file or directory
compilation terminated.
make: *** [makefile:413: lib/obj/stringifor_string_t.o] Error

Am I supposed to compile and install the libraries in src/third_party manually or is this a bug in the makefile?

@szaghi szaghi self-assigned this Jun 18, 2021
@szaghi
Copy link
Owner

szaghi commented Jun 18, 2021

Hi @moritzgubler

It is due (probably) to the fact that the makefile is not up-to-date. I'll try to fix it ASAP

szaghi added a commit that referenced this issue Jun 18, 2021
Fix issue #36: update makefile
@szaghi
Copy link
Owner

szaghi commented Jun 18, 2021

Hi @moritzgubler

I have just pushed a new release with an updated makefile, it seems to work for me. Please let me know if it fixes the issue also for you. Note that the third_party libraries are supposed to be compiled automatically by means of fobos/makefile, but be sure to have the sources downloaded, e.g. cloning the repository an all submodules with recursive cloning.

Thank you for reporting the bug, cheers

@szaghi szaghi added the bug label Jun 18, 2021
@moritzgubler
Copy link
Author

Hi @szaghi
Thanks for the quick fix. Make now successfully builds the library. The tests are also not working.
make TESTS=yes returns
make: *** No rule to make target src/tests/is_real.f90', needed by exe/obj/is_real.o'. Stop.

Cheers,
Moritz

szaghi added a commit that referenced this issue Jun 18, 2021
Fix issue #36: update makefile, tests were missing
@szaghi
Copy link
Owner

szaghi commented Jun 18, 2021

Hi @moritzgubler

I have just uploaded a new fix, let me know if you are able to compile and run tests.

Cheers

@moritzgubler
Copy link
Author

Hi @szaghi

Thanks for the update. I am still not able to test the library. make TESTS=yes now returns: make: *** No rule to make target exe/STRINGIFOR_TEST_CSV_NAIVE_PARSER', needed by .NOTPARALLEL'. Stop.

This is the case for a freshly pulled repository without any old executables laying around.

Cheers
Moritz

szaghi added a commit that referenced this issue Jun 22, 2021
Fix issue #36: correct typo into makefile
@szaghi
Copy link
Owner

szaghi commented Jun 22, 2021

@moritzgubler

I have just pushed a fix, there was a typo on the csv naive parser test rule.

Let me know if this works also for you (I am able to compile all tests with also the makefile, I use FoBiS that is the official building tool).

Cheers

@moritzgubler
Copy link
Author

The tests are now also working. Thanks for fixing this.

@szaghi
Copy link
Owner

szaghi commented Jun 28, 2021

@moritzgubler you are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants