[pull] master from juce-framework:master #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…le threads on macOS 10.13 or earlier On these platforms, calling flushBuffer from multiple threads simultaneously will lead to deadlocks.
Android devices won't necessarily be able to load MP3 files, so that option has been removed from the file chooser. FLAC files should be supported, but were missing from the MIME table. The demo no longer tries to load files into the thumbnail view if they previously failed to load into the transport.
…s if they are not handled by outer views
Until this commit it was possible that the message thread got stuck waiting for the WebBrowserComponent's thread to finish, while the thread was waiting for the message thread to handle a posted message.
In order to display a WebKit based webview a plugin will deploy a temporary standalone executable on the system and host the WebKit instance inside that.
- macOS behaviour of setRealtime now matches other platforms MR feedback
… are visible on-screen Running under Gnome, calling ComponentPeer::forceSetBounds immediately after creating a new peer causes the peer to emit a visibility-changed event because the window manager sometimes reports that the new window is in IconicState. _NET_WM_STATE_HIDDEN seems to more accurately reflect whether the window is really minimised or off-screen.
…uctor While improving Android IME support (da38c1e), text editor destructors were updated to explicitly pass keyboard focus elsewhere. As far as I remember, the change was intended to prevent the text input system from trying to send input events to components while they were being destroyed, in which case the TextInputTarget and Component bases may be 'valid', but the data members referenced by the TextInputTarget implementation may have been destroyed. The motivation for removing these lines is that giving away focus and sending a focus event can cause all components to become unfocused. This is problematic in the case of slider text editors - pressing 'enter' will cause the TextEditor to be destroyed, but the parent component will fail to gain focus, so pressing 'tab' will not have any effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )