[pull] master from juce-framework:master #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
… and ctrl modifiers
This commit contains an unmodified React app template. The interesting bit is the following commit that shows how to modify this template to interoperate with the JUCE framework.
COM objects now always start with a refcount of 1, as is convention.
This updates the behaviour of Typeface::getStringWidth, Typeface::getGlyphPositions, and Typeface::getEdgeTableForGlyph to match the documented behaviour of these functions. Previously, these functions returned results normalised to a size of 1 point. The new (documented) behaviour is to normalise to a JUCE height of 1.0 - that is, scaled so that the sum of the ascent and descent is equal to 1.0.
Previously, the UnitTestRunner example in the DemoRunner would fail on any tests that included ScopedJuceInitialiser_GUI, as DeletedAtShutdown objects would be destroyed too early.
Previously, the UnitTestRunner example in the DemoRunner would fail on any tests that included ScopedJuceInitialiser_GUI, as DeletedAtShutdown objects would be destroyed too early.
…lugin Reintegrates changes from 06a2089
…tate The base implementation of this function does nothing, and returns 'not implemented'. It is more correct to return 'ok', to indicate that setting the component state succeeded.
…window-management features like Aero Snap" This reverts commit adc63ce. Reverting this commit is only a temporary measure to facilitate a stable release of JUCE 8. Further work on this feature will continue on develop, and will likely be included in a future release of JUCE 8.
… points
Previously, code such as the following would return a smaller string
width for larger tracking values:
juce::Font f { juce::FontOptions{}.withPointHeight (16.0f) };
const auto g = f.withExtraKerningFactor (1.0f);
const auto a = f.getStringWidth ("foobar");
const auto b = g.getStringWidth ("foobar");
With this change applied, the width 'b' is greater than the width 'a',
as expected.
…er than current transform This assertion is intended to mirror the behaviour of an informational/performance diagnostic message raised by the D2D debugging layer. It seems the D2D diagnostic is raised when the proposed clip region is aligned to the screen, not to the current transform. Before this change, the assertion could incorrectly fire when clipping to transformed rectangles. This could be seen when clicking the star-shaped buttons in the ComponentTransformsDemo. With this change in place, the assertion will still fire when e.g. calling Graphics::reduceClipRegion on a screen-aligned rectangular path, but will not fire when this path is skewed/rotated etc.
…h NaN Without this change in place, setting the Value to NaN can cause a stack overflow because the old and new values always compare unequal, causing new change notifications to be sent.
Reading or writing the kAudioUnitProperty_AudioChannelLayout property could result in out-of-bounds reads or writes as AudioChannelLayout has a variable length array as the last member of the struct
… is added This is fixing a regression in f764026.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )