Skip to content

Commit

Permalink
VST3 Client: Avoid returning kResultNotImplemented from setComponentS…
Browse files Browse the repository at this point in the history
…tate

The base implementation of this function does nothing, and returns 'not
implemented'. It is more correct to return 'ok', to indicate that
setting the component state succeeded.
  • Loading branch information
reuk committed Jun 11, 2024
1 parent a42a498 commit 9c19294
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ class JuceVST3EditController final : public Vst::EditController,
#endif

//==============================================================================
tresult PLUGIN_API setComponentState (IBStream* stream) override
tresult PLUGIN_API setComponentState (IBStream*) override
{
// As an IEditController member, the host should only call this from the message thread.
assertHostMessageThread();
Expand All @@ -1065,7 +1065,7 @@ class JuceVST3EditController final : public Vst::EditController,
if (auto* handler = getComponentHandler())
handler->restartComponent (Vst::kParamValuesChanged);

return Vst::EditController::setComponentState (stream);
return kResultOk;
}

void setAudioProcessor (JuceAudioProcessor* audioProc)
Expand Down

0 comments on commit 9c19294

Please sign in to comment.