Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid lots and lots of announced addresses in the presence of symmetric NAT #4519

Closed
calmh opened this issue Nov 17, 2017 · 0 comments
Closed

Avoid lots and lots of announced addresses in the presence of symmetric NAT #4519

calmh opened this issue Nov 17, 2017 · 0 comments
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v0.14.41

Comments

@calmh
Copy link
Member

calmh commented Nov 17, 2017

When behind symmetric NAT we will get a new port mapping for every STUN lookup, which is (worst case) every 24 seconds. Worst case this means we accumulate up to 150 useless KCP addresses (one hour's worth) on the discovery server.

We should probably just not announce any KCP addresses to the global discovery system when we are behind an unfriendly NAT type.

Relates to #4459
@calmh calmh added the enhancement New features or improvements of some kind, as opposed to a problem (bug) label Nov 17, 2017
@calmh calmh added this to the Planned milestone Nov 17, 2017
AudriusButkevicius added a commit to AudriusButkevicius/syncthing that referenced this issue Nov 17, 2017
@AudriusButkevicius
lib/connections: Only announce punchable nats (fixes syncthing#4519)
a903592
@calmh calmh modified the milestones: Planned, v0.14.41 Dec 3, 2017
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 18, 2018
@syncthing syncthing locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v0.14.41
Development

No branches or pull requests
2 participants
@calmh @st-review