Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT CLOSE] [DO NOT MERGE] Ponder/message bus #2765

Closed
wants to merge 14 commits into from

Conversation

ChiTimesChi
Copy link
Collaborator

Description
Replaces #2514

Copy link
Contributor

coderabbitai bot commented Jun 21, 2024

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • WIP
  • DO NOT MERGE

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Jun 21, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 206d1e7
Status:🚫  Build failed.

View logs

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.09061%. Comparing base (b189451) to head (206d1e7).
Report is 574 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2765         +/-   ##
===================================================
+ Coverage   25.95177%   26.09061%   +0.13884%     
===================================================
  Files            737         679         -58     
  Lines          52744       50018       -2726     
  Branches          80          80                 
===================================================
- Hits           13688       13050        -638     
+ Misses         37649       35631       -2018     
+ Partials        1407        1337         -70     
Flag Coverage Δ
cctp-relayer ?
packages 90.47619% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 6, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 6, 2024
@ChiTimesChi ChiTimesChi removed the Stale label Jul 8, 2024
@trajan0x
Copy link
Contributor

@ChiTimesChi given that we're using this temporarily, any reason not to merge? Can nuke later

@ChiTimesChi
Copy link
Collaborator Author

ChiTimesChi commented Jul 10, 2024

@trajan0x I think this requires a few changes to the deployment configuration in railway.

It's currently tracking ponder/message-bus branch, so need to change it to master post-merge. Not exactly sure what happens between the branch is merged and config is updated, as the current branch gets deleted (though could immediately restore post-merge for a day).

I also believe the root directory needs to be configured so that the service is redeployed only after a change to the new package rather than on every commit to master. @abtestingalpha does this sound accurate?

Edit: probably just setting up the watch path for redeployment is enough w/o changing the root dir.

@abtestingalpha
Copy link
Collaborator

@trajan0x @ChiTimesChi

  1. Why we can't merge yet: This branch is currently breaking the synapse-interface frontend build. Looking at CF logs, CF is unable to download Node 18.18. Rebuilds don't fix this issue. Unclear why this is happening, but guessing there's a conflict related to sanguine packages and ponder (which recommends pnpm and a different version of viem).
  2. Since temporary, does this need to live in sanguine? If not, we can move it to its own repo with ponder-recommended package settings (pnpm) to avoid all these conflicts. And then point the railway build to that repo.

@ChiTimesChi
Copy link
Collaborator Author

This package isn't actually using anything from the monorepo afaik, so could totally live as a separate repo.

Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added Stale and removed Stale labels Aug 30, 2024
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added Stale and removed Stale labels Sep 29, 2024
@github-actions github-actions bot closed this Oct 11, 2024
@github-actions github-actions bot deleted the ponder/message-bus branch October 11, 2024 02:38
@ChiTimesChi ChiTimesChi restored the ponder/message-bus branch October 11, 2024 09:14
@ChiTimesChi ChiTimesChi reopened this Oct 11, 2024
@github-actions github-actions bot closed this Oct 15, 2024
@github-actions github-actions bot deleted the ponder/message-bus branch October 15, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants