-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT CLOSE] [DO NOT MERGE] Ponder/message bus #2765
Conversation
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2765 +/- ##
===================================================
+ Coverage 25.95177% 26.09061% +0.13884%
===================================================
Files 737 679 -58
Lines 52744 50018 -2726
Branches 80 80
===================================================
- Hits 13688 13050 -638
+ Misses 37649 35631 -2018
+ Partials 1407 1337 -70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
@ChiTimesChi given that we're using this temporarily, any reason not to merge? Can nuke later |
@trajan0x I think this requires a few changes to the deployment configuration in railway. It's currently tracking I also believe the root directory needs to be configured so that the service is redeployed only after a change to the new package rather than on every commit to master. @abtestingalpha does this sound accurate? Edit: probably just setting up the watch path for redeployment is enough w/o changing the root dir. |
|
This package isn't actually using anything from the monorepo afaik, so could totally live as a separate repo. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Description
Replaces #2514