Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] make:security:custom #19809

Open
wants to merge 1 commit into
base: 6.4
Choose a base branch
from
Open

[Security] make:security:custom #19809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion security/custom_authenticator.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ Symfony comes with :ref:`many authenticators <security-authenticators>` and
third party bundles also implement more complex cases like JWT and oAuth
2.0. However, sometimes you need to implement a custom authentication
mechanism that doesn't exist yet or you need to customize one. In such
cases, you must create and use your own authenticator.
cases, you can use the ``make:security:custom`` command to create your own
authenticator.
Comment on lines +8 to +9
Copy link
Contributor Author

@jrushlow jrushlow Apr 21, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. we reference the make:* command in the doctrine section like I have here.. But we use the code-block "syntax" else where in the doc's..

symfony-docs/security.rst

Line 727 in f7225d9

.. code-block:: terminal
I'm thinking we should make this a code block here?

Sidenote - I should probably change the

symfony-docs/doctrine.rst

Line 96 in f7225d9

You can use the ``make:entity`` command to create this class and any fields you
reference to a "code-block" style as well for consistency. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the terminal code block would be better because it stands out a lot and it's easier to scan fore readers. Thanks!


Authenticators should implement the
:class:`Symfony\\Component\\Security\\Http\\Authenticator\\AuthenticatorInterface`.
Expand Down