Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding group_by #16179

Open
wants to merge 1 commit into
base: 5.4
Choose a base branch
from
Open

Adding group_by #16179

wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link
Contributor

I didn't check if others are missing too...

@ThomasLandauer
Adding group_by
5cf04d0 
I didn't check if others are missing too...
@carsonbot carsonbot added this to the 5.4 milestone Nov 30, 2021
@xabbuh
Copy link
Member

xabbuh commented Dec 1, 2021

Would it make sense to move all options out of the ChoiceType into a dedicated file and include that one everywhere where we need to render these options? This would also reduce the risk of forgetting any of them in the future once new options are added.

@ThomasLandauer
Copy link
Contributor Author

ThomasLandauer commented Dec 13, 2021 •
edited
Loading

Sorry, I don't know what's the best way to organize this :-(

But choice_label is missing too.

@ThomasLandauer ThomasLandauer mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasLandauer @xabbuh @carsonbot