Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the doc clearer about front controller files checked by Symfony CLI #15035

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Feb 26, 2021

Closes symfony/cli#416

@carsonbot carsonbot added this to the 4.4 milestone Feb 26, 2021
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice change imho. Thanks Fabien!

(please allow me to request doing the same explicitness for the "supported docker services" section, explaining how Symfony CLI detects a specific service. E.g. I often need to search in the Fast Track book to find which mailcatcher image I should use, given there is no official one)

@fabpot
Copy link
Member Author

fabpot commented Feb 26, 2021

Done in #15036

@javiereguiluz
Copy link
Member

This is now more precise and easier to understand. Thanks Fabien!

@javiereguiluz javiereguiluz merged commit 8af4865 into symfony:4.4 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants