Fix broken link for multiple messenger buses #12638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Nov 16, 2019
OskarStark
approved these changes
Nov 18, 2019
|
Thank you Fabien! I changed a minor in 2d6b1df |
OskarStark
added a commit
that referenced
this pull request
Nov 18, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Fix broken link for multiple messenger buses There is an incorrect link in the documentation of the messenger component for multiple buses. The broken link is visible [here](https://symfony.com/doc/current/messenger/message-recorder.html) and the bug is present for 4.3, 4.4 and current documentation. I don't know if I use the correct syntax. I just copy/past a different declaration that works in https://symfony.com/doc/current/messenger.html#multiple-buses-command-event-buses. Commits ------- e21be6c Fix broken link for multiple messenger buses
OskarStark
added a commit
that referenced
this pull request
Nov 18, 2019
OskarStark
added a commit
that referenced
this pull request
Nov 18, 2019
* 4.3: use a lovercase title for the link. refs #12638 fix supported installable version formats Fix broken link for multiple messenger buses remove gender-related terms from HTTP fundamentals diagrams
OskarStark
added a commit
that referenced
this pull request
Nov 18, 2019
* 4.4: use a lovercase title for the link. refs #12638 fix supported installable version formats Fix broken link for multiple messenger buses remove gender-related terms from HTTP fundamentals diagrams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an incorrect link in the documentation of the messenger component for multiple buses. The broken link is visible here and the bug is present for 4.3, 4.4 and current documentation.
I don't know if I use the correct syntax. I just copy/past a different declaration that works in https://symfony.com/doc/current/messenger.html#multiple-buses-command-event-buses.