Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the configuration references #10000

Closed
wants to merge 2 commits into from
Closed

Improved the configuration references #10000

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

Changes done:

  • Added the missing options listing for TwigBundle
  • Fixed indenting of sub-options (they were being generated as <ul> + <dl> + <ul> instead of <ul> + <ul>)
  • Sorted lists of options alphabetically (very important for readers, especially for long lists of options. As we talked in the past, we only sort the list of options, not the option descriptions ... to avoid all the merging nightmares).
  • Added some CSS classes to all the config option lists (so we can later improve how they look on symfony.com)

@javiereguiluz javiereguiluz added this to the 2.8 milestone Jul 3, 2018
@javiereguiluz
Copy link
Member Author

I've built docs locally and it looks like these changes are working as expected, so we can merge them:

config-options

@javiereguiluz javiereguiluz mentioned this pull request Jul 3, 2018
Merged
javiereguiluz added a commit that referenced this pull request Jul 3, 2018
@javiereguiluz
minor #10002 Fixed a minor sorting error (javiereguiluz)
f8f945d 
This PR was merged into the 2.8 branch.

Discussion
----------

Fixed a minor sorting error

After merging #10000, I found two minor issues. This one fixes the first issue.

Commits
-------

20606eb Fixed a minor sorting error
@javiereguiluz javiereguiluz mentioned this pull request Jul 3, 2018
Merged
javiereguiluz added a commit that referenced this pull request Jul 3, 2018
@javiereguiluz
minor #10003 Fixed another issue cause by options reorganization (jav…
872aca7 
…iereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Fixed another issue cause by options reorganization

This is the second issue I found after merging #10000. After merging this, everything should be fine again.

Commits
-------

9c7902c Fixed another issue cause by options reorganization
@javiereguiluz javiereguiluz mentioned this pull request Jul 3, 2018
Merged
javiereguiluz added a commit that referenced this pull request Jul 3, 2018
@javiereguiluz
minor #10006 Fixed more sorting issues in config options (javiereguiluz)
1c855de 
This PR was merged into the 2.8 branch.

Discussion
----------

Fixed more sorting issues in config options

Another minor sorting issue related to #10000.

Commits
-------

8dc76e1 Fixed more sorting issues in config options
@javiereguiluz javiereguiluz mentioned this pull request Jul 3, 2018
Merged
javiereguiluz added a commit that referenced this pull request Jul 3, 2018
@javiereguiluz
minor #10007 Fixed a nested option syntax issue (javiereguiluz)
6c7c8c3 
This PR was merged into the 4.0 branch.

Discussion
----------

Fixed a nested option syntax issue

Minor issue after merging #10000 in upper branches. I'll submit another PR ... but that will be the last one!

Commits
-------

3054edd Fixed a nested option syntax issue
@javiereguiluz javiereguiluz mentioned this pull request Jul 3, 2018
Merged
javiereguiluz added a commit that referenced this pull request Jul 3, 2018
@javiereguiluz
minor #10008 Fixed some nested options issues (javiereguiluz)
b484c8b 
This PR was merged into the 4.1 branch.

Discussion
----------

Fixed some nested options issues

The last fix related to #10000 🎉

Commits
-------

962c36d Fixed some nested options issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javiereguiluz @HeahDude @carsonbot