Fix command-line arguments & allow using env vars and wildcard IP addresses for server #18
+45
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using PHP 7.2.2 on Windows, testing this code in the WebServerManager:
And I have this output:
The first one is wrong, so I decided to refactor it with a plain
array_merge()
that will surely be working 👍This PR also introduces lots of other changes that allow using env vars and ips like
0.0.0.0
for servers listening to any host. I thought it would be a really nice improvement