Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooling to compare reference and updated output #1

Conversation

jonwis
Copy link

@jonwis jonwis commented Jul 10, 2023

Here's some scripts to help validate the comparison. I wish cmd.exe had a better built-in text manipulation tool. Powershell makes this easy; routing through "copy + findstr /v" is very slow.

The comparison looks pretty reasonable on the Big Windows metadata.

@sylveon
Copy link
Owner

sylveon commented Jul 11, 2023

Looks great! I'd suggest adding .ixx to the prepare_versionless_diffs.cmd tool's list of files, as otherwise it misses modules (the current winrt.ixx + future changes which might add more).

Also I hit a footgun with this: I ran build_protection.cmd without rebuilding the cppwinrt binary first when switching branches - suggest either making the script build cppwinrt.exe or mentioning that pitfall in the README.

@sylveon
Copy link
Owner

sylveon commented Jul 11, 2023

Also, I don't think anybody would mind a PowerShell script instead ;)

Jon Wiswall added 3 commits July 11, 2023 13:19
@jonwis
Copy link
Author

jonwis commented Jul 11, 2023

Alrighty, done. Powershell and doc update.

@sylveon sylveon merged commit 39cbe93 into sylveon:user/sylveon/protected-members Jul 11, 2023
@jonwis jonwis deleted the user/jonwis/protected-members branch August 17, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants