Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image preview: in WhatsApp, feed readers and others #163

Merged
merged 2 commits into from
Jun 4, 2019

Conversation

mhagnumdw
Copy link
Contributor

(draft)

Hi!

Let me know if you are interested in continuing this task. I think it's worth it, but we'll have to see the issue since the default images in the project is webp.

I needed to generate:
triangle .svg > triangle .png
desk-messy .webp > desk-messy .jpg

Before

WhatsApp

type on strap print thumbnail blog no whatsapp

https://feedly.com

Antes Peek 2019-05-30 13-20

After

WhatsApp

Depois whatsapp

https://feedly.com

Depois Peek 2019-05-30 13-10

@sylhare
Copy link
Owner

sylhare commented May 31, 2019

This is good feedback!

I have added this new .webp format because it is recommended as new and lightweight for the internet. It's too bad that webp is not yet recognized by those apps and feed readers.

I believe that on a normal use people would use jpg and png. (Even though I have added the gulp task for .webp if one wants to reduce the image load on the website).

I know there's a new jpg format that is highly compressed, if it works with it, we could switch to this one for the sake of having the image displayed. I would need to investigate on that.

The goal would be to find a lightweight format that can also be displayed on those feeds.

@sylhare
Copy link
Owner

sylhare commented May 31, 2019

The other jpg format (JPEG XR and JPEG 2000) are even less supported that webp. Maybe we can add jpg images for the ones on the blog. or add a warning for webp format?

Or maybe a jpg fallback if the webp, svg can't be read?

@mhagnumdw
Copy link
Contributor Author

mhagnumdw commented May 31, 2019

For a same image we could have two versions: jpg and webp?
jpg if necessary, of course.

Or maybe a jpg fallback if the webp, svg can't be read?

Good idea!

sylhare added a commit that referenced this pull request Jun 3, 2019
@sylhare sylhare marked this pull request as ready for review June 3, 2019 19:37
@sylhare
Copy link
Owner

sylhare commented Jun 3, 2019

I will for the theme put the images that are seen in jpeg. I will merge you change with the feed.xml and the .png image.
I have tried a bit for having both (like a fallback) and it's complicated without js 😅

@sylhare
Copy link
Owner

sylhare commented Jun 4, 2019

Nice! Thanks ;)

@sylhare sylhare merged commit acf8be9 into sylhare:master Jun 4, 2019
OMEGA-Y pushed a commit to OMEGA-Y/OMEGA-Y.github.io that referenced this pull request Dec 8, 2020
re: sylhare#163

Citation style used: Science of Computer Programming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants