Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrows not going to the top of the page on "tags" page #7

Closed
sylhare opened this issue Oct 30, 2017 · 6 comments
Closed

Arrows not going to the top of the page on "tags" page #7

sylhare opened this issue Oct 30, 2017 · 6 comments
Assignees
Labels

Comments

@sylhare
Copy link
Owner

sylhare commented Oct 30, 2017

It seems the anhor on the tags.html page is not working or that the current URL to go to that anchor is not working https://sylhare.github.io/Type-on-Strap/tags/#tags.

I will need to correct that.

@sylhare sylhare added the bug label Oct 30, 2017
@sylhare sylhare added this to the Enhancing Template milestone Oct 30, 2017
@sylhare sylhare self-assigned this Oct 30, 2017
@sylhare
Copy link
Owner Author

sylhare commented Nov 2, 2017

Ok this is basic html in fact ...
The key to create an anchor is to have the field id populated with the anchor name, so that your link get you to there.

<h1 id=anchor>I am an anchor</h1>

<a href="#anchor">I am a link to that anchor above</a>

Then you mix it with liquid tags and you can optimize your jekyll page!

sylhare added a commit that referenced this issue Nov 3, 2017
@sylhare
Copy link
Owner Author

sylhare commented Nov 3, 2017

This fixed, Will be pushed into master at the next release.

@sylhare sylhare closed this as completed Nov 3, 2017
@sylhare sylhare added this to to do in Type-on-Strap via automation Nov 4, 2017
@sylhare sylhare moved this from to do to Done in Type-on-Strap Nov 4, 2017
sylhare added a commit that referenced this issue Nov 9, 2017
@arthurlacoste
Copy link
Contributor

This is not working on your demo, and either in my tests.

@sylhare sylhare reopened this Nov 10, 2017
Type-on-Strap automation moved this from Done to to do Nov 10, 2017
@sylhare
Copy link
Owner Author

sylhare commented Nov 10, 2017

Allo,

I have tested it on the demo, it brings back to the title of the page when you click on the arrow (on firefox).

  • Did you try with the latest version of the project?
  • What browser are you using for the demo?

@arthurlacoste
Copy link
Contributor

arthurlacoste commented Nov 10, 2017

Sorry, I guess I need to open a new issue, it's more about tag page itself (there is one?)

kapture 2017-11-11 at 0 24 01

Page link is like this : http:https://127.0.0.1:4000/pages/tags/#micodeyt

I've try in dev & master branch without success.

And the tag pages doesn't seems to work on your demo too.

@sylhare
Copy link
Owner Author

sylhare commented Nov 11, 2017

Oh ok I see, nice catch ;)

@sylhare sylhare closed this as completed Nov 11, 2017
Type-on-Strap automation moved this from to do to Done Nov 11, 2017
jougene added a commit to jougene/jougene.github.io that referenced this issue Nov 29, 2017
OMEGA-Y pushed a commit to OMEGA-Y/OMEGA-Y.github.io that referenced this issue Dec 8, 2020
* added design.md
added : currency-exchange/.meta/design.md
gmoon92 pushed a commit to gmoon92/gmoon92.github.io that referenced this issue Oct 5, 2021
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this issue Mar 8, 2022
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this issue Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Type-on-Strap
  
Done
Development

No branches or pull requests

2 participants