Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header image "over scrolls" on page #5

Closed
sylhare opened this issue Oct 30, 2017 · 2 comments
Closed

Header image "over scrolls" on page #5

sylhare opened this issue Oct 30, 2017 · 2 comments

Comments

@sylhare
Copy link
Owner

sylhare commented Oct 30, 2017

The image overscroll on the page, so instead of the image being blocked at its end, it continues going down as I scroll. It should stop scrolling at the bottom of the image.

Plus the background: no-repeat; was not set on the page layout.

@sylhare sylhare self-assigned this Oct 30, 2017
@sylhare sylhare added this to the Enhancing Template milestone Oct 30, 2017
@sylhare
Copy link
Owner Author

sylhare commented Oct 30, 2017

That's because when you resize the windows the header image size changes.

sylhare added a commit that referenced this issue Oct 31, 2017
@sylhare
Copy link
Owner Author

sylhare commented Oct 31, 2017

The complexity comes from the bacground-size of the background-image in the div that is set to cover. So the ratio is always moved based on the size of the window.
The actual size of the background-image is a bit tricky to get, but possible.

However I did not wanted to have multiple javascript functions for that, so instead I have adjusted the background-size based on the size of the screen so it matches the scrolling pace at all time.
It seems to work on big images, but my trick won't work on smaller images...

Might be improved later, but good for now.

@sylhare sylhare closed this as completed Oct 31, 2017
@sylhare sylhare added this to to do in Type-on-Strap via automation Nov 4, 2017
@sylhare sylhare moved this from to do to Done in Type-on-Strap Nov 4, 2017
jougene added a commit to jougene/jougene.github.io that referenced this issue Nov 29, 2017
craigonaonewheel pushed a commit to craigonaonewheel/craigonaonewheel.github.io that referenced this issue Sep 11, 2018
OMEGA-Y pushed a commit to OMEGA-Y/OMEGA-Y.github.io that referenced this issue Dec 8, 2020
* Add codeowners file

* Update CODEOWNERS
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this issue Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Type-on-Strap
  
Done
Development

No branches or pull requests

1 participant