Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header_text_feature_image not displayed properly on mobile(android) browser #34

Closed
yshrsmz opened this issue Dec 11, 2017 · 11 comments
Closed
Labels

Comments

@yshrsmz
Copy link
Contributor

yshrsmz commented Dec 11, 2017

https://yshrsmz.github.io/

So here is my page.
when I browse this page on Android Chrome, header_text_feature_image is not displayed properly(it's way smaller than the display). it's displayed at the left side at first, and when I scroll it will be aligned to right.

Your demo page's header image ( https://sylhare.github.io/Type-on-Strap/ ) also looks strange. its width looks like wider than the display, but when you scroll, it becomes same width as display

@yshrsmz
Copy link
Contributor Author

yshrsmz commented Dec 11, 2017

Oh, it's not android problem, if you make your PC browser's width small enough, you'll see what I mean

@sylhare
Copy link
Owner

sylhare commented Dec 11, 2017

Hi, can you do a screenshot, I have trouble seeing what you mean.

Maybe it has to do with the size of your picture? I will check what's up.

@yshrsmz
Copy link
Contributor Author

yshrsmz commented Dec 11, 2017

Sorry for my english.
Here's screenshot's

Before scroll After scroll

You can see obvious difference on my site. But even with your site, header image is wider than the parent width, and when you scroll, it matches parent's width.

https://github.com/yshrsmz/yshrsmz.github.io/blob/master/assets/img/dactyl.jpg
here's my image if you need.

thanks.

@sylhare
Copy link
Owner

sylhare commented Dec 11, 2017

Ok I'll make some tests, thanks.

sylhare added a commit that referenced this issue Dec 12, 2017
@sylhare
Copy link
Owner

sylhare commented Dec 12, 2017

So, I fixed the glitch with the scrolling. (It should not move anymore now).

Now for your image, the blue (behind) is because of the image ratio (it should be a bit more rectangular like the one I am using).
So you can either:

  • Crop your image to a better ratio
  • Try with another image
  • Update _index/scss in the .call-out check the "responsive" and update with something like:
    /* --- Responsive ---*/
    @media screen and (max-width: 730px) {
        background-size: auto 200%;
    }

or remove it entirely.

@yshrsmz
Copy link
Contributor Author

yshrsmz commented Dec 12, 2017

thanks!

@yshrsmz yshrsmz closed this as completed Dec 12, 2017
@yshrsmz yshrsmz reopened this Dec 12, 2017
@yshrsmz
Copy link
Contributor Author

yshrsmz commented Dec 12, 2017

I updated image with more rectangular one, but still having problem.
It looks like header image's width is depending on header text.
If you replace your header text with shorter one(such as <p>This is test header</p>), your image will not be displayed properly

I've attached an image to better explain the behavior. I just replaced header text with <p>test</p>.
screenshot

@sylhare
Copy link
Owner

sylhare commented Dec 12, 2017

Oh that's interesting, I'll investigate ;)

@yshrsmz
Copy link
Contributor Author

yshrsmz commented Dec 13, 2017

Let me correct my previous comment. it looks like header image's width is depending on the height of div#main. (Yes, this is what background-size: auto 150% means)

Since auto retains image's ratio, image cannot match the parent width if div#main does not have enough height,

sylhare added a commit that referenced this issue Dec 13, 2017
@sylhare
Copy link
Owner

sylhare commented Dec 13, 2017

Hi, since I don't have a solution for a scaling slightly bigger header image, I'll let it on cover that should solve your problem.
Once I have a solution I will re-implement the feature

@sylhare sylhare closed this as completed Dec 13, 2017
sylhare added a commit that referenced this issue Dec 15, 2017
@sylhare
Copy link
Owner

sylhare commented Dec 15, 2017

I'll make it available only for short text, since it's not made to m=put as much text as I did. so I'm changing the _config.yml
It should be now 100% width on the page for smaller screen.
I'll merge the branch when ready.

@sylhare sylhare reopened this Dec 15, 2017
@sylhare sylhare mentioned this issue Dec 15, 2017
@sylhare sylhare added the bug label Dec 15, 2017
@sylhare sylhare closed this as completed Dec 15, 2017
gmoon92 pushed a commit to gmoon92/gmoon92.github.io that referenced this issue Oct 5, 2021
gmoon92 pushed a commit to gmoon92/gmoon92.github.io that referenced this issue Oct 5, 2021
gmoon92 pushed a commit to gmoon92/gmoon92.github.io that referenced this issue Oct 5, 2021
gmoon92 pushed a commit to gmoon92/gmoon92.github.io that referenced this issue Oct 5, 2021
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this issue Mar 8, 2022
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this issue Mar 8, 2022
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this issue Mar 8, 2022
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this issue Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants