Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change #portfolio in the CSS causing problems if as a portfolio tag #20

Closed
sylhare opened this issue Nov 10, 2017 · 1 comment
Closed

Change #portfolio in the CSS causing problems if as a portfolio tag #20

sylhare opened this issue Nov 10, 2017 · 1 comment
Assignees
@sylhare
Labels
bug
Projects
Type-on-Strap
Milestone
Enhancing Template

Comments

@sylhare
Copy link
Owner

sylhare commented Nov 10, 2017

The #portoflio in the portfolio _sass can cause a conflict with the _tag page.
Tags are generated and an id is given to them.

I will change the ID for the portfolio layout and sass and use a class to avoid that kind of conflict.
@sylhare sylhare added the bug label Nov 10, 2017
@sylhare sylhare added this to the Enhancing Template milestone Nov 10, 2017
@sylhare sylhare self-assigned this Nov 10, 2017
@sylhare sylhare added this to to do in Type-on-Strap via automation Nov 10, 2017
sylhare added a commit that referenced this issue Nov 13, 2017
@sylhare
Fixing #20
d393822
@sylhare
Copy link
Owner Author

sylhare commented Nov 13, 2017 •
edited
Loading

Replaced #portfolio by .portfolio

@sylhare sylhare closed this as completed Nov 13, 2017
Type-on-Strap automation moved this from to do to Done Nov 13, 2017
jougene added a commit to jougene/jougene.github.io that referenced this issue Nov 29, 2017
@jougene
Fixing sylhare#20
7796a88
gmoon92 pushed a commit to gmoon92/gmoon92.github.io that referenced this issue Oct 5, 2021
@sylhare
Fixing sylhare#20
a5dfdd8
gmoon92 added a commit to gmoon92/gmoon92.github.io that referenced this issue Mar 8, 2022
@gmoon92
Fixing sylhare#20
4deb4cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylhare sylhare

Labels
bug
Projects
No open projects
Type-on-Strap
  
Done
Milestone
Enhancing Template
Development

No branches or pull requests
1 participant
@sylhare