hcl/parser: support bools in lists

syl20bnr · Jan 20, 2017 · e59762b · e59762b
1 parent eb6f65b
commit e59762b
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 3 deletions.
diff --git a/decoder_test.go b/decoder_test.go
@@ -391,6 +391,23 @@ func TestDecode_interface(t *testing.T) {
  true,
  nil,
  },
+
+ {
+ "object_with_bool.hcl",
+ false,
+ map[string]interface{}{
+ "path": []map[string]interface{}{
+ map[string]interface{}{
+ "policy": "write",
+ "permissions": []map[string]interface{}{
+ map[string]interface{}{
+ "bool": []interface{}{false},
+ },
+ },
+ },
+ },
+ },
+ },
  }
 
  for _, tc := range cases {

diff --git a/hcl/parser/parser.go b/hcl/parser/parser.go
@@ -346,7 +346,7 @@ func (p *Parser) listType() (*ast.ListType, error) {
  }
  }
  switch tok.Type {
- case token.NUMBER, token.FLOAT, token.STRING, token.HEREDOC:
+ case token.BOOL, token.NUMBER, token.FLOAT, token.STRING, token.HEREDOC:
  node, err := p.literalType()
  if err != nil {
  return nil, err
@@ -388,8 +388,6 @@ func (p *Parser) listType() (*ast.ListType, error) {
  }
  l.Add(node)
  needComma = true
- case token.BOOL:
- // TODO(arslan) should we support? not supported by HCL yet
  case token.LBRACK:
  // TODO(arslan) should we support nested lists? Even though it's
  // written in README of HCL, it's not a part of the grammar

diff --git a/hcl/parser/parser_test.go b/hcl/parser/parser_test.go
@@ -58,6 +58,10 @@ func TestListType(t *testing.T) {
  `foo = [123, "123",]`,
  []token.Type{token.NUMBER, token.STRING},
  },
+ {
+ `foo = [false]`,
+ []token.Type{token.BOOL},
+ },
  {
  `foo = []`,
  []token.Type{},

diff --git a/test-fixtures/object_with_bool.hcl b/test-fixtures/object_with_bool.hcl
@@ -0,0 +1,6 @@
+path {
+ policy = "write"
+ permissions = {
+ "bool" = [false]
+ }
+}