Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow building with the system Lua #943

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Kladki
Copy link
Contributor

@Kladki Kladki commented Apr 23, 2024

Still defaults to vendored lua, but that can be overridden by using --no-default-features

@sxyazi
Copy link
Owner

sxyazi commented Apr 24, 2024

Thanks for the PR!

Could you add default = ["vendored-lua"] to each crate instead of just adding it to yazi-fm?

I think this would be more robust, as for example yazi-dds is not only depended on by yazi-fm but also by yazi-cli, yazi-core, yazi-scheduler, etc.

@Kladki
Copy link
Contributor Author

Kladki commented Apr 24, 2024

Ah ok. That would require building with --workspace to be able to build with system lua, but I can see that the robustness may be worth it.

yazi-fm/Cargo.toml Outdated Show resolved Hide resolved
@sxyazi sxyazi changed the title build: allow using system lua feat: allow building with the system Lua Apr 24, 2024
@sxyazi sxyazi merged commit 8456d3a into sxyazi:main Apr 24, 2024
5 checks passed
@Kladki
Copy link
Contributor Author

Kladki commented Apr 24, 2024 via email

@Kladki Kladki deleted the optional-vendored-lua branch April 26, 2024 19:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants