Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback to built-in highlighting if jq is not installed #151

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

ndtoan96
Copy link
Contributor

Currently, if jq is not available, there's no preview for json file. We should fall back to text in that case.

@sxyazi
Copy link
Owner

sxyazi commented Sep 13, 2023

Great idea! can you add that fallback inside the Provider::json function?

@sxyazi
Copy link
Owner

sxyazi commented Sep 13, 2023

Thank you!

@sxyazi sxyazi merged commit 9c6b3c9 into sxyazi:main Sep 13, 2023
@sxyazi sxyazi changed the title Fall back to text if json provider is not available feat: fallback to built-in highlighting if jq is not installed Sep 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants