Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use system headers for system libnghttp2 #5038

Merged
merged 1 commit into from
May 6, 2023

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Apr 26, 2023

Affects 5.0.3, removing thirdparty/nghttp2 (to ensure bundled copy is not used) and using --with-nghttp2-dir=/usr

In file included from /dev/shm/BUILD/php-pecl-swoole5-5.0.3/NTS/ext-src/swoole_admin_server.cc:19:
/dev/shm/BUILD/php-pecl-swoole5-5.0.3/NTS/ext-src/php_swoole_http.h:37:10: fatal error: thirdparty/nghttp2/nghttp2.h: No such file or directory
   37 | #include "thirdparty/nghttp2/nghttp2.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

This may raise strange issue using bundled headers with system library (API may differ)

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #5038 (2714169) into master (0d83f46) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5038      +/-   ##
==========================================
+ Coverage   73.11%   73.13%   +0.02%     
==========================================
  Files          69       69              
  Lines       14793    14793              
==========================================
+ Hits        10816    10819       +3     
+ Misses       3977     3974       -3     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matyhtf matyhtf merged commit 39ffab5 into swoole:master May 6, 2023
@remicollet remicollet deleted the issue-fixinc branch May 7, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants