Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blinking props #8

Closed
QBLes opened this issue Jun 23, 2022 · 7 comments
Closed

Blinking props #8

QBLes opened this issue Jun 23, 2022 · 7 comments

Comments

@QBLes
Copy link

QBLes commented Jun 23, 2022

So i noticed when a user flys in every sprop thats being spawned starts blinking, if i restart the script props are static but if you restart fivem its all on the blink again.

swkeep added a commit that referenced this issue Jun 23, 2022
@swkeep swkeep closed this as completed Jun 29, 2022
@QBLes
Copy link
Author

QBLes commented Jun 29, 2022

Nice one on the fix, but now it does not load them at all unless you restart script.

@swkeep
Copy link
Owner

swkeep commented Jun 29, 2022

it's strange they are using the same functions there is no different between them

@swkeep swkeep reopened this Jun 29, 2022
@QBLes
Copy link
Author

QBLes commented Jun 29, 2022

no idea bro, once servers up and running i need to restart script in order for props to spawn..

@swkeep
Copy link
Owner

swkeep commented Jun 29, 2022

there is an event called 'QBCore:Client:OnPlayerLoaded' try to find it and put a print('test') after Wait.
here
then restart your client and check if it gets triggered or not!

@QBLes
Copy link
Author

QBLes commented Jun 29, 2022

Ok so i noticed in the updated version you have it does a job check to make sure they have the job, i removed this to look just how you have it and it now works.

This is how your released version looks:

if PlayerJob.name == 'oilwell' then
      OnDuty = PlayerData.job.onduty
      loadData()
 end

i also noticed no matter what parts you put in the stash it takes everything when fixing it, so if i put 100 of one part it takes all 100 when doing a repair.

Thanks for the tips bro, 'keep' up the good work

@swkeep
Copy link
Owner

swkeep commented Jun 29, 2022

got i fixed job check in my uncommitted version. (it's gonna be a big rework!)

about parts, it might be annoying but i wanted to be players to think about how much they are willing to put in there.
and somewhat scared of using it to hide stuff inside the oil wells.
it was auto removal at first every 10 sec but it was using too much resources.

@QBLes
Copy link
Author

QBLes commented Jun 29, 2022

got i fixed job check in my uncommitted version. (it's gonna be a big rework!)

about parts, it might be annoying but i wanted to be players to think about how much they are willing to put in there. and somewhat scared of using it to hide stuff inside the oil wells. it was auto removal at first every 10 sec but it was using too much resources.

oh i see, i never knew this when i first tested it lol, i was like what the hell it took everything, im sure i could code it how i want it i guess, i dont like editing peoples code much, makes it easier to do updates that way lol

Millusion added a commit to Millusion/keep-oilwell that referenced this issue Jul 8, 2022
@swkeep swkeep closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants