Add changes for baseline 16.0.0 support #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pdm commands 4 and 5 also changed |
yellows8
reviewed
Feb 25, 2023
nx/source/services/fs.c
Outdated
| @@ -520,7 +535,7 @@ Result fsIsSignedSystemPartitionOnSdCardValid(bool *out) { | |||
| } | |||
|
|
|||
| Result fsGetRightsIdByPath(const char* path, FsRightsId* out_rights_id) { | |||
| if (hosversionBefore(2,0,0)) | |||
| if (hosversionBefore(2,0,0) || hosversionAtLeast(16,0,0)) | |||
yellows8
approved these changes
Mar 2, 2023
ncm: update bindings for 16.0.0 changes ncm: fix missing rename on GetPatchContentMetaId ncm: they broke serialization ordering by changing type alignment ncm: remove alignment on content id/placeholder id
fs: add new ContentAttributes enum fs: add version check fs: use hosversionBetween
vi: fix duplicate decl of Indirect service vi: fix style vi: use s32 over int vi: fix argument names for FatalDrawRectangle
|
Great work on this! Will a docker image be provided soon as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shouldn't be merged yet, and is for getting in anything libnx needs for 16.0.0 support.