improved XXE SVG payloads to be valid XMLs #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while testing for XXEs in SVG I needed to make some changes so that the payloads are treated as valid XMLs. I thought it's worth doing a pr so that nobody misses an XXE because of lack of required attribute.
I fixed 2 things actually:
image tag for XXE inside SVG
I was validating my payloads here and when you use Validate by Direct Input, choose SVG 1.1 DOCTYPE and paste
There are 2 errors:
and the same for height.
Thus I added them to the XXE SVG payload.
xml tag in OOB via SVG rasterization
I added XML tag as without it my payload was causing exceptions. On the aforementioned validator it's still not considered valid, but adding it made the payload work in my case.
Both fixes made my XXE work during the pentest and those payloads didn't work without them.