-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented legend positioning, fixes #135 #842
Implemented legend positioning, fixes #135 #842
Conversation
…itions for the legend
Hey, is this going to be merged? |
Hi, can someone please provide status on this PR ? I am in need of this functionality at my current project. It is very nice feature to have. Thanks. |
This feature will be awesome!!! |
@achanta3215 I see a progress here. Will there be merged soon? please notice in the package.json file that the version is for 9+ (9.01?!) |
We would also love this feature. Is a merge planned? |
Thank you! Will be making slight adjustments (centering and horizontal scroll) before releasing. |
When setting legend position to 'below' and the chart should fit to container (no 'view'-attribute), the legend isnt visible. The chart uses the whole container height and the legend is invisible below the chart. |
…itions for the legend (swimlane#842)
…itions for the legend (swimlane#842)
…itions for the legend (swimlane#842)
Is it possible to set the legend position to top? |
Implemented legend positioning, with right and below as supported positions for the legend. Fixes #135.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The legend is currently always displayed to the right of the chart
What is the new behavior?
Using the
legendPosition
input, the legend can now be shown either right or below the chart. It also opens the possibility to introduce other positions like above or left of the chart.Does this PR introduce a breaking change? (check one with "x")