Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented legend positioning, fixes #135 #842

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

flore2003
Copy link
Contributor

@flore2003 flore2003 commented May 18, 2018

Implemented legend positioning, with right and below as supported positions for the legend. Fixes #135.

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The legend is currently always displayed to the right of the chart

What is the new behavior?
Using the legendPosition input, the legend can now be shown either right or below the chart. It also opens the possibility to introduce other positions like above or left of the chart.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@bop10
Copy link
Contributor

bop10 commented Jul 5, 2018

Hey, is this going to be merged?

Merraclius pushed a commit to daprime-com/ngx-charts that referenced this pull request Jul 17, 2018
@pathakparth
Copy link

Hi, can someone please provide status on this PR ? I am in need of this functionality at my current project. It is very nice feature to have.

Thanks.

@harellevy
Copy link

This feature will be awesome!!!
Is it going to be merged soon? looking forward for legend positioning 👍 🥇

@harellevy
Copy link

@achanta3215 I see a progress here. Will there be merged soon? please notice in the package.json file that the version is for 9+ (9.01?!)

@tobigit
Copy link
Contributor

tobigit commented Oct 5, 2018

We would also love this feature. Is a merge planned?

@marjan-georgiev marjan-georgiev merged commit 6893f83 into swimlane:master Oct 18, 2018
@marjan-georgiev
Copy link
Member

Thank you! Will be making slight adjustments (centering and horizontal scroll) before releasing.

@tobigit
Copy link
Contributor

tobigit commented Nov 12, 2018

When setting legend position to 'below' and the chart should fit to container (no 'view'-attribute), the legend isnt visible. The chart uses the whole container height and the legend is invisible below the chart.
Does the height-calculation not take care of the legend height?

oNguyenMinhHong pushed a commit to oNguyenMinhHong/ngx-charts that referenced this pull request Nov 19, 2018
bartes pushed a commit to bartes/ngx-charts that referenced this pull request Nov 26, 2018
bartes pushed a commit to bartes/ngx-charts that referenced this pull request Nov 26, 2018
@rudifernandes
Copy link

Is it possible to set the legend position to top?
:/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend Positions
8 participants