[windows][build.ps1] only use swift-corelibs-foundation-windows checkout #75140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in CI swiftlang#75073 has broken a local toolchain build on windows using build.ps1, as the local build does not use update_checkout on windows, and thus does not checkout swift-corelibs-foundation-windows.
|
@swift-ci please test |
|
@swift-ci please build windows toolchain |
|
CC: @iCharlesHu |
compnerd
approved these changes
Jul 10, 2024
jmschonfeld
reviewed
Jul 10, 2024
| # a checkout that does not yet use swift-foundation. | ||
| $RepoName = "swift-corelibs-foundation-windows"; | ||
| } else { | ||
| $RepoName = "swift-corelibs-foundation"; |
There was a problem hiding this comment.
Where does the script that specifies swift-corelibs-foundation for local builds live? Is it currently checking out main or windows/main?
There was a problem hiding this comment.
That is at https://github.com/compnerd/swift-build/blob/main/default.xml#L20. It should checkout windows/main for now and will need to be changed back to main once main restores the ability to build for Windows.
jmschonfeld
approved these changes
Jul 10, 2024
|
@swift-ci please build windows toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in CI
#75073 has broken a local toolchain build on windows using build.ps1,
as the local build does not use update_checkout on windows, and thus does not checkout swift-corelibs-foundation-windows.