Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows][toolchain] build android compiler-rt builtins when buildin… #74754

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jun 26, 2024

…g Android SDK with build.ps1

@hyp hyp requested a review from compnerd as a code owner June 26, 2024 21:46
@hyp
Copy link
Contributor Author

hyp commented Jun 26, 2024

@swift-ci please build toolchain

@hyp hyp requested a review from hjyamauchi June 26, 2024 21:47
@hyp hyp force-pushed the eng/android-compiler-rt-buildps1 branch from ffeb9cc to 4c9a444 Compare June 26, 2024 21:49
@hyp
Copy link
Contributor Author

hyp commented Jun 26, 2024

@swift-ci please build toolchain

cmake/caches/Windows-aarch64.cmake Outdated Show resolved Hide resolved
cmake/caches/Windows-aarch64.cmake Outdated Show resolved Hide resolved
utils/build.ps1 Show resolved Hide resolved
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments are minor, going to just approve this.

@hyp
Copy link
Contributor Author

hyp commented Jun 27, 2024

this needs more work I think , let's hold off

@hyp hyp force-pushed the eng/android-compiler-rt-buildps1 branch from 9453db6 to bd2c3ea Compare July 13, 2024 00:23
@hyp
Copy link
Contributor Author

hyp commented Jul 13, 2024

@compnerd updated, it works and installs properly now, please take another look.

@hyp
Copy link
Contributor Author

hyp commented Jul 15, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jul 15, 2024

@swift-ci please build toolchain

hyp added 2 commits July 15, 2024 13:01
build ps1 is currently not able to compile the arm64 builtins correctly
@hyp
Copy link
Contributor Author

hyp commented Jul 15, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jul 15, 2024

@swift-ci please build toolchain

@hyp
Copy link
Contributor Author

hyp commented Jul 15, 2024

The arm64 side needs more work, but this lets us build the android builtins on a windows x64 host.

@hyp
Copy link
Contributor Author

hyp commented Jul 16, 2024

@swift-ci please test windows platform

@hyp
Copy link
Contributor Author

hyp commented Jul 16, 2024

@swift-ci build windows toolchain

@hyp
Copy link
Contributor Author

hyp commented Jul 16, 2024

@swift-ci please test windows

@hyp
Copy link
Contributor Author

hyp commented Jul 16, 2024

@swift-ci please smoke test

@hyp
Copy link
Contributor Author

hyp commented Jul 16, 2024

@swift-ci please test windows

@hyp
Copy link
Contributor Author

hyp commented Jul 16, 2024

@swift-ci please smoke test

@compnerd
Copy link
Member

@swift-ci please test Windows platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants