[NFC] Add -enable-import-ptrauth-field-function-pointers as a no-op #74703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
porglezomp
reviewed
Jun 25, 2024
There was a problem hiding this comment.
I was the one who requested this because I was concerned about the migration path for people using this flag, since:
- Swift 6.0 requires the flag to enable the feature, since it wasn't default-on there
- Without this change, the flag would be immediately removed without it being default-on, so there was no compatible option across compilers
This looks good to me, but just commenting rather than approving because I don't feel qualified to review from the compiler-side PoV.
Comment on lines
1261
to
1263
| def enable_import_ptrauth_field_function_pointers : | ||
| Flag<["-"], "enable-import-ptrauth-field-function-pointers">, | ||
| HelpText<"Enable import of custom ptrauth qualified field function pointers">; |
There was a problem hiding this comment.
Since this is defaulting on—do we want this hidden? (Or: I guess this is already in --help-hidden?)
Do we want the help message to mention it's default-on?
There was a problem hiding this comment.
Turns out it is in --help-hidden already. I can update the help message. Thanks
|
@swift-ci smoke test |
porglezomp
reviewed
Jun 26, 2024
Co-authored-by: Cassie Jones <[email protected]>
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar:https://129305855