[6.0] [stdlib] (U)Int128 improvements #74691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[stdlib] Mark UInt128.Words as frozen
[stdlib] Apply @_transparent consistently for (U)Int128
|
@swift-ci please test |
tbkka
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UInt128.Wordswasn't correctly marked as@frozenhindering the optimizer's ability to help specialize uses of these types. This also applies@_transparentto most functionality of 128 bit integers (where necessary) and provides a specialized implementation of_lowWordas well.UInt128.Wordsas@frozenis ABI breaking, but hopefully we can land this before it becomes an actual issue. The rest of the changes are low risk.Int128andUInt128APIs have different attributes #74481