Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Complete migration from CODE_OWNERS.txt #73511

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented May 8, 2024

  • @akyrtzi Do you want me to assign you to IDE, Index, SourceKit, and swift-ide-test files per the old CODEOWNERS.txt?
  • @belkadan Do you by chance know who took charge of serialization & frontend files? Do you want to receive notifications about PRs that modify these files?
  • @DougGregor @eeckstein @nkcsgexi @rjmccall @jckarter @slavapestov I migrated the CODEOWNERS.txt info associated with you to the new format. This means that you will start receiving notifications about PRs that modify the files you own per the old specification. Please let me know if I missed anything, the old specification is outdated, or you do not want to receive notifications.
  • @jckarter Is you being a code owner of "everything in Swift not covered by someone else" still accurate? If we are going to add a mapping for this, I propose to keep it as a comment until we reach a decent coverage rate, or else your mailbox might go ballistic 🙂.
  • @adrian-prantl @artemcm @tshortli @compnerd Assigned you to a few more places you seem to have missed based on existing mappings.

@AnthonyLatsis AnthonyLatsis requested review from xedin and hborla May 8, 2024 15:22
@AnthonyLatsis AnthonyLatsis changed the title .github: Complete migration from CODEOWNERS.txt .github: Complete migration from CODEOWNERS.txt May 8, 2024
@tshortli
Copy link
Contributor

tshortli commented May 8, 2024

Do you by chance know who took charge of Serialization & Frontend files?

Serialization would be @xymus. I'll ask around about Frontend.

@akyrtzi
Copy link
Contributor

akyrtzi commented May 8, 2024

@akyrtzi Do you want me to assign you to IDE, Index, SourceKit, and swift-ide-test files per the old CODEOWNERS.txt?

No, it should be @bnbarham

@tshortli
Copy link
Contributor

tshortli commented May 8, 2024

@artemcm and I can be listed for Frontend.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xymus Mapped you to serialization files. This means that you will start receiving notifications about PRs that modify these files. Please let me know if I missed anything or you if do not want to receive notifications.

@AnthonyLatsis AnthonyLatsis changed the title .github: Complete migration from CODEOWNERS.txt .github: Complete migration from CODE_OWNERS.txt May 23, 2024
@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Jul 3, 2024

All right, this seems good to go, so I have resurrected CODE_OWNERS.TXT to unblock the change. We will delete it once an updated code ownership governance lands on the website.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis merged commit 215ddc4 into swiftlang:main Jul 4, 2024
3 checks passed
@AnthonyLatsis AnthonyLatsis deleted the olea-europaea branch July 6, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants