Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Use clang.arc.attachedcall for emission of objc_retainAutoreleasedReturnValue" #68488

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert "Revert "Use clang.arc.attachedcall for emission of objc_retainAutoreleasedReturnValue" #68488

wants to merge 2 commits into from
+43 −5

Conversation

meg-gupta
Copy link
Contributor

Also add an optnone test

@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#7456

@swift-ci test

@meg-gupta meg-gupta marked this pull request as ready for review September 13, 2023 19:28
aschwaighofer
aschwaighofer approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Swift Part LGTM

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer approved these changes

@ahmedbougacha ahmedbougacha Awaiting requested review from ahmedbougacha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meg-gupta @aschwaighofer