Sema: Improve diagnostics for decls more available than their containers #62900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers. Adopt new request-based utilities for looking up the enclosing declaration's availability when type checking an `@available` attribute. This consolidates implementations of the lookup and improves diagnostics by catching more cases where declarations are more available than their containers.
d49c9fa
to
abf4d12
Compare
|
@swift-ci please test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 21, 2023
…tainer. It turns out that we must allow declarations with `introduced:` availability nested inside of other declarations that are `unavailable` in order to influence weak linking. Stop diagnosing declarations as being more available than their unavailable containers and revert some changes to availability inference that were designed to avoid creating these nestings but caused regressions for declarations marked `@_spi_available.` Reverts parts of swiftlang#64310, swiftlang#64015, and swiftlang#62900.
etcwilde
pushed a commit
to etcwilde/swift
that referenced
this pull request
Apr 19, 2023
…tainer. It turns out that we must allow declarations with `introduced:` availability nested inside of other declarations that are `unavailable` in order to influence weak linking. Stop diagnosing declarations as being more available than their unavailable containers and revert some changes to availability inference that were designed to avoid creating these nestings but caused regressions for declarations marked `@_spi_available.` Reverts parts of swiftlang#64310, swiftlang#64015, and swiftlang#62900.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt new request-based utilities for looking up the enclosing declaration's availability when type checking an
@availableattribute. This consolidates implementations of the lookup and improves diagnostics by catching more cases where declarations are more available than their containers.Builds on #62876.