Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on wide pages #741

Closed
wants to merge 1 commit into from
Closed

Conversation

rauhul
Copy link
Contributor

@rauhul rauhul commented Jun 25, 2024

Updates the page templates to use "wide" pages everywhere instead of mix of wide and narrow pages.

@rauhul
Copy link
Contributor Author

rauhul commented Jun 25, 2024

@swift-ci test

@federicobucchi
Copy link
Contributor

Didn't we decide to keep the pages with a lot of text narrow (for not having the user to have difficulty on reading) and the ones that allow a "multiple columns" template to have the wide template?

@rauhul
Copy link
Contributor Author

rauhul commented Jun 27, 2024

Is this something than can be revisited? The different page width look more like a bug than an intentional choice. Is there some prior art of language sites that act like this?

@federicobucchi
Copy link
Contributor

We can chat about it, but it would take a longer discussion. But, just wanted to let you know, that this was decided for the reason above. Making all the pages wide, does bring real problems for readers.

@rauhul
Copy link
Contributor Author

rauhul commented Jun 27, 2024

How does one join/have that discussion?

@federicobucchi
Copy link
Contributor

We can have the conversation in here, or in https://forums.swift.org

For reference: #499 (comment)

@rauhul
Copy link
Contributor Author

rauhul commented Jun 28, 2024

I see, I think the points presented there are fair enough, and probably not worth pushing for a better solution right now

Copy link
Contributor

@federicobucchi federicobucchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please feel free to close the PR

@rauhul rauhul closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants