Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From the embedded page, link to the tools page to set up editors #740

Merged

Conversation

ahoppen
Copy link
Contributor

@ahoppen ahoppen commented Jun 25, 2024

No description provided.

Copy link
Contributor

@dempseyatgithub dempseyatgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and for updating to a more appropriate link!

I didn't do a full on 'request change' but please consider using my suggested change.

@@ -215,7 +215,7 @@ Hooray! Our first *host-side* Embedded Swift program is working!
- The [Embedded Swift Vision Document](https://github.com/swiftlang/swift-evolution/blob/main/visions/embedded-swift.md) will give you an overview of the approaches and goals of Embedded Swift, and also what exactly is in the Embedded Swift language subset.
- The [collection of Embedded Swift example projects](https://github.com/apple/swift-embedded-examples) on GitHub shows on which embedded devices can Swift work today, and the examples can also be used as templates for your own projects.
- The [Embedded Swift User Manual](https://github.com/apple/swift/blob/main/docs/EmbeddedSwift/UserManual.md) describes how to use the Embedded Swift compilation mode and how to interact with the compiler.
- You might want to set up [Swift editor integration via SourceKit-LSP](https://github.com/swiftlang/sourcekit-lsp) to get features like indexing, autocomplete, jump-to-definition, show declarations/documentations, etc. to work in your favorite editor or IDE.
- To set up Swift integration in your editor, read one of our [setup guides](https://www.swift.org/tools/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- To set up Swift integration in your editor, read one of our [setup guides](https://www.swift.org/tools/).
- The [Tools page](https://www.swift.org/tools/) has guides for setting up Swift integration in your editor to enable features like indexing, autocomplete, jump-to-definition, and others.

All the other bullet points in the list start with the name of the resource being recommended. This suggestion matches the style of the other bullet points and preserves a shortened version of the benefit to the reader of following the link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also include the #editors anchor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Thanks!

@ahoppen ahoppen force-pushed the embedded-editor-using-tools-page branch from e8999cd to b995038 Compare June 26, 2024 04:13
@rauhul
Copy link
Contributor

rauhul commented Jun 27, 2024

@swift-ci test

Copy link
Contributor

@dempseyatgithub dempseyatgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - thank you!

@dempseyatgithub dempseyatgithub merged commit 47595e4 into swiftlang:main Jun 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants