Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiX: adjust installer images according to official Swift logo guidelines #214

Merged
merged 1 commit into from
Jul 21, 2023
Merged

WiX: adjust installer images according to official Swift logo guidelines #214

merged 1 commit into from
Jul 21, 2023

Conversation

lxbndr
Copy link
Contributor

@lxbndr lxbndr commented Jul 21, 2023

  • Correct background orange color
  • Rounded corners instead of square logo shape

@lxbndr
WiX: adjust installer images according to official Swift logo guidelines
4c6d83f 
- Correct background orange color
- Rounded corners instead of square logo shape
@lxbndr
Copy link
Contributor Author

lxbndr commented Jul 21, 2023

cc @compnerd

compnerd
compnerd approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@compnerd compnerd merged commit 3e41380 into swiftlang:main Jul 21, 2023
@lxbndr lxbndr deleted the swifty-orange branch July 21, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lxbndr @compnerd