Allow TaskGroup's ChildTaskResult Type To Be Inferred #2494
Conversation
proposals/NNNN-allow-taskgroup-childtaskresult-type-to-be-inferred.md
Outdated
Show resolved
Hide resolved
proposals/NNNN-allow-taskgroup-childtaskresult-type-to-be-inferred.md
Outdated
Show resolved
Hide resolved
proposals/NNNN-allow-taskgroup-childtaskresult-type-to-be-inferred.md
Outdated
Show resolved
Hide resolved
proposals/NNNN-allow-taskgroup-childtaskresult-type-to-be-inferred.md
Outdated
Show resolved
Hide resolved
proposals/NNNN-allow-taskgroup-childtaskresult-type-to-be-inferred.md
Outdated
Show resolved
Hide resolved
proposals/NNNN-allow-taskgroup-childtaskresult-type-to-be-inferred.md
Outdated
Show resolved
Hide resolved
Thank you for looking over everything. I have implemented the suggestions and updated a spots of grammar. Should I go ahead and tag this as |
|
Yeap, please mark as ready to review! :) |
rjmccall
added
the
LSG
…the first sentence of the Design Details section.
|
|
||
| ## Detailed design | ||
|
|
||
| Because type inference is top-down, it relies on the first statement that uses `group` to infer determine the generic for `ChildTaskResult`. Therefore, it is possible to get a compiler error by creating a task group where the first use of `group` does not use `addTask(...)`, like so: |
There was a problem hiding this comment.
| Because type inference is top-down, it relies on the first statement that uses `group` to infer determine the generic for `ChildTaskResult`. Therefore, it is possible to get a compiler error by creating a task group where the first use of `group` does not use `addTask(...)`, like so: | |
| Because type inference is top-down, it relies on the first statement that uses `group` to infer the generic arguments for `ChildTaskResult`. Therefore, it is possible to get a compiler error by creating a task group where the first use of `group` does not use `addTask(...)`, like so: |
There was a problem hiding this comment.
Thanks for the suggestion.
There was a problem hiding this comment.
Thank you! I'll kick the review off shortly.
| // Expect `ChildTaskResult` to be `Int`... | ||
| withTaskGroup(of: Int.self) { group in | ||
| group.cancelAll() | ||
| group.addTask { 42 } |
There was a problem hiding this comment.
I think it would be beneficial to have some more realistic examples. For example, there are small-but-realistic examples at https://www.avanderlee.com/concurrency/task-groups-in-swift/ and https://www.kodeco.com/books/modern-concurrency-in-swift/v1.0/chapters/7-concurrent-code-with-taskgroup that you could reference (with attribution!) and will give reviewers a better feel for how this impacts use of the feature.
There was a problem hiding this comment.
I have updated the examples to use more real-world scenarios. Thank you for the suggestion. 👍
Original discussion here: https://forums.swift.org/t/allow-taskgroups-childtaskresult-type-to-be-inferred/72175
See: swiftlang/swift#74517