Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TaskGroup's ChildTaskResult Type To Be Inferred #2494

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rlziii
Copy link

@rlziii rlziii commented Jun 18, 2024

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Minor ideas to improve proposal and we can ask the core team for a review 👍

@rlziii
Copy link
Author

rlziii commented Jun 19, 2024

Looks good to me! Minor ideas to improve proposal and we can ask the core team for a review 👍

Thank you for looking over everything. I have implemented the suggestions and updated a spots of grammar. Should I go ahead and tag this as Ready for review?

@ktoso
Copy link
Contributor

ktoso commented Jun 20, 2024

Yeap, please mark as ready to review! :)

@rlziii rlziii marked this pull request as ready for review June 20, 2024 13:53
@rjmccall rjmccall added the LSG Contains topics under the domain of the Language Steering Group label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSG Contains topics under the domain of the Language Steering Group
Projects
None yet
3 participants