Isolated synchronous deinit and asynchronous deinit #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuswntr
reviewed
May 2, 2023
proposals/0371-isolated-synchronous-deinit-and-asynchronous-deinit.md
Outdated
Show resolved
Hide resolved
- synchronous deinit is nonisolated by default - async deinit - attribute to control task-local usage
b342f55
to
56ef108
Compare
ktoso
reviewed
Jul 2, 2024
ktoso
approved these changes
Jul 2, 2024
Jumhyn
reviewed
Jul 21, 2024
| class Bar { | ||
| @SecondActor | ||
| deinit {} // Isolated on SecondActor | ||
| If containing class is not isolated, it is still possible to use global actor attribute on `deinit`. |
There was a problem hiding this comment.
Suggested change
| If containing class is not isolated, it is still possible to use global actor attribute on `deinit`. | |
| If the containing type is not isolated, it is still possible to use a global actor attribute on `deinit`. |
There was a problem hiding this comment.
I don't want to use type to avoid giving false impression that this feature can be used with move-only value types.
|
|
||
| ### Isolated deinit of default actors | ||
| For isolated synchronous `deinit`, this cost increases. For each class in the hierarchy `swift_task_deinitOnExecutor()` will be called, but slow path can be taken only for the most derived class. Other classes in the hierarchy would be doing redundant actor checks. To avoid this, isolated deinit bypasses Objective-C runtime when calling isolated `deinit` of Swift base classes, and calls `__isolated_deallocating_deinit` directly. Compatibility with Objective-C is preserved only on Swift<->Objective-C boundary in either direction. |
There was a problem hiding this comment.
This is also a bit implementation-y, any way we could rephrase in terms of the actual language model?
There was a problem hiding this comment.
Reworded a bit, but it still contains mentions __isolated_deallocating_deinit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second iteration of the proposal: