[lldb] Add type summary for String.Index #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
cc @lorentey in case you have any thoughts |
|
@swift-ci test |
augusto2112
approved these changes
Oct 27, 2022
lldb/test/API/functionalities/data-formatter/swift/string-index/main.swift
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift/string-index/main.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci test |
kastiglione
commented
Oct 28, 2022
...test/API/functionalities/data-formatter/swift/string-index/TestSwiftStringIndexFormatters.py
Outdated
Show resolved
Hide resolved
|
@swift-ci test |
kastiglione
added a commit
that referenced
this pull request
Nov 2, 2022
Implement a type summary for Swift's `String.Index`. The summary string follows the following: 1. Original proposal: https://forums.swift.org/t/improving-string-index-s-printed-descriptions/57027 2. Proposed implementation: swiftlang/swift#58479 3. Temporary(ish) near-`CustomStringConvertible` implementation: swiftlang/swift#61548 The associated test cases are taken from the test cases in swiftlang/swift#58479. rdar:https://99211823 (cherry picked from commit c7146a3)
kastiglione
added a commit
that referenced
this pull request
Feb 9, 2023
Implement a type summary for Swift's `String.Index`. The summary string follows the following: 1. Original proposal: https://forums.swift.org/t/improving-string-index-s-printed-descriptions/57027 2. Proposed implementation: swiftlang/swift#58479 3. Temporary(ish) near-`CustomStringConvertible` implementation: swiftlang/swift#61548 The associated test cases are taken from the test cases in swiftlang/swift#58479. rdar:https://99211823 (cherry picked from commit c7146a3)
kastiglione
added a commit
that referenced
this pull request
Feb 9, 2023
Implement a type summary for Swift's `String.Index`. The summary string follows the following: 1. Original proposal: https://forums.swift.org/t/improving-string-index-s-printed-descriptions/57027 2. Proposed implementation: swiftlang/swift#58479 3. Temporary(ish) near-`CustomStringConvertible` implementation: swiftlang/swift#61548 The associated test cases are taken from the test cases in swiftlang/swift#58479. rdar:https://99211823 (cherry picked from commit c7146a3)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a type summary for Swift's
String.Index.The summary string follows the following:
CustomStringConvertibleimplementation: [stdlib] String.Index: Add _description & _debugDescription swift#61548The associated test cases are taken from the test cases in swiftlang/swift#58479.
rdar:https://99211823