#95 ignore white spaces before and after quotes/fields/values #96
Conversation
There was a problem hiding this comment.
Looks good so far, thanks for adding the test case and providing a fix!
Would be great if you could add unit tests for other whitespace characters that should be skipped, too. Tabs come to mind; more exotic spaces like the non-breaking space (⌥+space on some keyboard layouts) would be optional "stretch goals" :)
SwiftCSVTests/CSVTests.swift
Outdated
| @@ -122,4 +122,14 @@ class CSVTests: XCTestCase { | |||
| XCTAssert(error is CSVParseError) | |||
| } | |||
| } | |||
|
|
|||
| func testInit_ParseFileWithQuotesAndSpaces() { | |||
There was a problem hiding this comment.
Since the implementation checks for isWhitespace, could you add similar-looking test cases for other whitespace characters, too?
enhanced the test data
Ok ok. Added more test data (using https://developer.apple.com/documentation/swift/character/3127019-iswhitespace). That that is pretty much the intent of this PR. |
|
We've invited you to join the SwiftCSV GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines. |
Fixes #95