-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.10 uses SNAPSHOT dependencies #1053
Comments
I think it is not OK. Swagger-Parser release 1.0.43 has a dependency to I understand that SNAPSHOT can be useful during development (and even there I prefer to work with released version on the master branches. For me using a SNAPSHOT version is only allowed on feature branches -- having a strong rule like this can be discussed, it is a mater of taste). For releases, having SNAPSHOT in the dependency tree is a bad practice. Are you using a specific maven profile when you do the release? Maybe we can configure the |
To prevent situations like this in the future, I propose to let maven fail if a release is built with some a SNAPSHOT versions in the dependency tree:
|
This makes it mandatory to add https://oss.sonatype.org/content/repositories/snapshots/ as a repository which is not so obvious reading the documentation as the parser release 2.0.10 is not a snapshot version. |
Thanks @slinkydeveloper for spotting and reporting, and @jmini for the PRs; no snapshot dep should have make it to release, enforcer was planned but unfortunately not yet applied, so thanks again and please use 1.0.44 / 2.0.11 being released in the next hours |
Thank you a lot for the quick reaction |
Hi,
Is it ok that release 2.0.10 uses snapshots from transitive dep swagger-parser 1.0.43?
The text was updated successfully, but these errors were encountered: