Use JSONValue instead of Any for Swift 5 #9896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlineholm
changed the title
ghost
force-pushed
the
hlineholm/use-jsonvalue
branch
from
cdbe81c
to
4ae2e89
Compare
ghost
force-pushed
the
hlineholm/use-jsonvalue
branch
from
4ae2e89
to
5ef4574
Compare
|
thanks a lot @hlineholm for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
I wasn't able to run the integration tests as I could install sudo gem install autotest-fsevent -v '0.2.12' on my machine, got Darwin 19 is not (yet) supported (RuntimeError).
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.I cannot add reviewers. This PR should be review by @ehyche.
Description of the PR
Empty objects { ... } in the swagger specification is generated as an Any type which doesn't conform to Codable in Swift and that will result in a build error. In my case it isn't an error as the specification is correct. We want to send unspecified json values for some of our properties.
To solve this, I've replaced the use of the type Any with a new custom type, the JSONValue. When creating it, I used sergiosette's gist and article.