Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for properties in ComposedModel #9827

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

gracekarina
Copy link
Contributor

@gracekarina gracekarina commented Nov 2, 2019

PR checklist

Branch: Master

Description of the PR

refs - swagger-api/swagger-parser/issues/1143 - Adding support for properties in ComposedModel
depends on swagger-api/swagger-parser#1241

@frantuma
Copy link
Member

please build

2 similar comments
@frantuma
Copy link
Member

please build

@frantuma
Copy link
Member

please build

@frantuma
Copy link
Member

please build

@frantuma
Copy link
Member

please build

@spacether
Copy link

spacether commented Nov 15, 2019

@gracekarina thank you for fixing this. On a related note
Additional properties should also be allowed in composed schemas, but that feature is blocked by a bug in swagger-parser swagger-api/swagger-parser#1252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants