Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring][Issue-9820] Adding cookie parameter to operation for generation (3.0.13) #9825

Closed
wants to merge 2 commits into from

Conversation

nataliaoliveira
Copy link

@nataliaoliveira nataliaoliveira commented Oct 31, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Issue: #9820

This change goes along with another change in swagger-codegen-generators. Please review PR swagger-api/swagger-codegen-generators#524

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@nataliaoliveira nataliaoliveira changed the title [issue-9820] Adding cookie parameter to operation for generation [Spring][Issue-9820] Adding cookie parameter to operation for generation Oct 31, 2019
@nataliaoliveira nataliaoliveira changed the title [Spring][Issue-9820] Adding cookie parameter to operation for generation [Spring][Issue-9820] Adding cookie parameter to operation for generation (3.0.13) Oct 31, 2019
@nataliaoliveira
Copy link
Author

@HugoMario @frantuma can you please check?

@frantuma
Copy link
Member

Thanks for this! We are going to review in the next days

@nataliaoliveira
Copy link
Author

Hi @frantuma! Any updates?

@frantuma
Copy link
Member

Replaced this PR with #9869, which doesn't include the updated samples, which will be added in later release. Thanks a lot for your contribution here and in swagger-api/swagger-codegen-generators#524 (included in swagger-api/swagger-codegen-generators/pull/543)

@frantuma frantuma closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants