#9808 - Dart double cast #9809
Merged
#9808 - Dart double cast #9809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have added a check for null before parsing |
|
Hey just wondering the likelihood of this PR being merged, or if there's anything further I can do to get it merged? |
|
@MichaelMarner I saw The Travis CI build failed, have you try to solve it? |
|
@skordesign sync'd with master, which made Travis pass. Thanks |
|
Any update? Still open? |
|
Why no one accept the PR? |
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This PR resolves #9808 by explicitly casting double properties from JSON payloads before assignment. This works around dart's JsonCodec parsing numbers that look like ints to
int, which cannot then be assigned directly to adouble.This PR takes advantage of the fact all Dart's number types have a
toDoublemethod. As long as the JSON payload contains a number, callingtoDoubleis safe.@ircecho